-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gvfs: block unsupported commands when running in a GVFS repo #91
Conversation
The following commands and options are not currently supported when working in a GVFS repo. Add code to detect and block these commands from executing. 1) fsck 2) gc 4) prune 5) repack 6) submodule 8) update-index --split-index 9) update-index --index-version (other than 4) 10) update-index --[no-]skip-worktree 11) worktree Signed-off-by: Ben Peart <benpeart@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My "request changes" is just a wait for #90, the v2.20 update in VFS, and a functional test build in VFS. I triggered the functional tests in this VFS for Git PR.
not_with_gvfs update-index --split-index | ||
not_with_gvfs worktree list | ||
|
||
test_expect_success 'test gc --auto succeeds when disabled via config' ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this test! Let's also get VFS functional tests before we merge. We will also want to retest the CI builds after #90 merges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The VFS functional tests are available in this PR:
microsoft/VFSForGit#597
I'm about to close and reopen to trigger the PR build again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are unblocked for merging.
gvfs: block unsupported commands when running in a GVFS repo
gvfs: block unsupported commands when running in a GVFS repo
gvfs: block unsupported commands when running in a GVFS repo
gvfs: block unsupported commands when running in a GVFS repo
gvfs: block unsupported commands when running in a GVFS repo
gvfs: block unsupported commands when running in a GVFS repo
gvfs: block unsupported commands when running in a GVFS repo
gvfs: block unsupported commands when running in a GVFS repo
gvfs: block unsupported commands when running in a GVFS repo
gvfs: block unsupported commands when running in a GVFS repo
The following commands and options are not currently supported when working
in a GVFS repo. Add code to detect and block these commands from executing.
Signed-off-by: Ben Peart benpeart@microsoft.com