Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main (1.19) and main FIPS tags #127

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

dagood
Copy link
Member

@dagood dagood commented Jun 3, 2022

Add microsoft/go main builds to the microsoft/go-images microsoft/nightly branch. Add FIPS tags that build on top of them and set GOEXPERIMENT=opensslcrypto by default.

The plan is to only build main tags in this repo's microsoft/nightly branch, not the MAR/MCR-targeting microsoft/main branch. Builds that come out of microsoft/go's microsoft/main branch never belong on MAR, only in our public ACR for evaluation purposes.

Once 1.19 is released and there's a release branch, the FIPS tags will be included in MAR builds.

Having go-images produce nightly builds based on microsoft/main will help us make sure our microsoft/main changes are ready for the coming 1.19 release. In the future it will help with 1.20, etc.

Review tips:

Example internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1806155&view=results

@dagood dagood marked this pull request as ready for review June 3, 2022 23:53
Copy link
Contributor

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dagood dagood requested review from chsienki and jaredpar June 21, 2022 21:23
@dagood dagood merged commit de4ad0d into microsoft:microsoft/nightly Jun 21, 2022
@dagood dagood deleted the dev/dagood/main-boring branch June 21, 2022 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants