releasego azure linux update: regexp readability, handle "$" #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #166 (comment). Making the group numbers (
[2],${1},${3}) into constants (and doing nothing else) leads to clutter and long names, but we can still do a lot better by putting the usage right next to the regexp to make it easy to read and modify in the future.I can imagine writing an extra abstraction on top of these "find/replacers" to make all of this even tidier, but it doesn't seem necessary here. It could actually hurt by making things less flexible.
Also, a couple other changes targeting readability:
$rather than erroring out isn't (currently) functionally useful, but doing so simplifies the code, so go ahead and do it.updateSpecFileto group the replacements together.