Skip to content

Add --version flag #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 15, 2022
Merged

Add --version flag #100

merged 12 commits into from
Sep 15, 2022

Conversation

stuartpa
Copy link
Collaborator

@stuartpa stuartpa commented Jun 22, 2022

Resolves issue #94

@stuartpa stuartpa marked this pull request as ready for review June 22, 2022 15:56
@stuartpa
Copy link
Collaborator Author

stuartpa commented Jun 22, 2022

Right now when built in the pipeline this PR is product a version number like:

sqlcmd --version
sqlcmd: v20220622.2

which is based off the $(Build.BuildNumber) value.

We need it to be:

sqlcmd --version
sqlcmd: v0.8.0-1

I'm investigating


In reply to: 1163362419

@shueybubbles
Copy link
Collaborator

shueybubbles commented Jul 14, 2022

Can you fix the diff not to have so much whitespace change?


In reply to: 1184570575

Copy link
Collaborator

@shueybubbles shueybubbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@stuartpa stuartpa force-pushed the stuartpa/dashdashversion branch from c1107a6 to a0abeed Compare September 7, 2022 14:19
@stuartpa stuartpa force-pushed the stuartpa/dashdashversion branch from a0abeed to 677001a Compare September 7, 2022 14:24
@shueybubbles
Copy link
Collaborator

shueybubbles commented Sep 7, 2022

    displayName: Set last tag to variable

i think this task has to move into the first stage


In reply to: 1239671640


Refers to: build/azure-pipelines/build-product.yml:58 in 75c7dfe. [](commit_id = 75c7dfe, deletion_comment = False)

@shueybubbles
Copy link
Collaborator

shueybubbles commented Sep 8, 2022

  - v*

add a branch constraint here for main unless we are confident we won't push version tags to other branches incorrectly.


In reply to: 1240755228


Refers to: build/azure-pipelines/build-product.yml:4 in 75c7dfe. [](commit_id = 75c7dfe, deletion_comment = False)

@stuartpa
Copy link
Collaborator Author

  - v*

add a branch constraint here for main unless we are confident we won't push version tags to other branches incorrectly.

Refers to: build/azure-pipelines/build-product.yml:4 in 75c7dfe. [](commit_id = 75c7dfe, deletion_comment = False)

Did you add this yesterday as part of another PR?

@shueybubbles
Copy link
Collaborator

  - v*

never mind, that doesn't work like I thought it does.


In reply to: 1240755228


Refers to: build/azure-pipelines/build-product.yml:4 in 75c7dfe. [](commit_id = 75c7dfe, deletion_comment = False)

Copy link
Collaborator

@shueybubbles shueybubbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stuartpa stuartpa merged commit 82dffe0 into main Sep 15, 2022
@stuartpa stuartpa deleted the stuartpa/dashdashversion branch September 15, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants