Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use x/sys/windows instead of syscall #197

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Use x/sys/windows instead of syscall #197

wants to merge 14 commits into from

Commits on Apr 21, 2021

  1. Revert "Replace local *FileInformationByHandleEx with x/sys/windows" 

    This reverts commit bfd5468.

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
    @katiewasnothere
    katiewasnothere committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    d80ed10 View commit details
    Browse the repository at this point in the history

  2. Revert "Implement winio.GetFileStandardInfo" 

    This reverts commit ef753e6.

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
    @katiewasnothere
    katiewasnothere committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    e5bd3f6 View commit details
    Browse the repository at this point in the history

  3. Add CI github action for testing on push and PR 

    Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
    @katiewasnothere
    katiewasnothere committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    085c1a9 View commit details
    Browse the repository at this point in the history

  4. Merge pull request microsoft#205 from katiewasnothere/gh_actions 

    Add CI github action for testing on push and PR
    @katiewasnothere
    katiewasnothere authored Apr 21, 2021
    Configuration menu
    Copy the full SHA
    3e47278 View commit details
    Browse the repository at this point in the history

  5. Add build status badge to readme 

    Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
    @katiewasnothere
    katiewasnothere committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    090e4c6 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Merge pull request microsoft#206 from katiewasnothere/build_badge 

    Add build status badge to readme
    @katiewasnothere
    katiewasnothere authored Apr 22, 2021
    Configuration menu
    Copy the full SHA
    4ee6e51 View commit details
    Browse the repository at this point in the history

  2. Build the three binaries in this repo from the ci 

    Even though this repo is normally used as a dependency, there are some
sample binaries and tools built out of here. This just makes sure they still build
in the CI.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
    @dcantah
    dcantah committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    1358edb View commit details
    Browse the repository at this point in the history

  3. Merge pull request microsoft#208 from dcantah/build-bins-ci 

    Build the three binaries in this repo from the ci
    @dcantah
    dcantah authored Apr 22, 2021
    Configuration menu
    Copy the full SHA
    a6ee88c View commit details
    Browse the repository at this point in the history

  4. Merge pull request microsoft#204 from katiewasnothere/revert_fileinfo… 

    …_break

[Temporary] Revert Implement winio.GetFileStandardInfo FileInfo commits
    @katiewasnothere
    katiewasnothere authored Apr 22, 2021
    Configuration menu
    Copy the full SHA
    5c2e05d View commit details
    Browse the repository at this point in the history

  5. Revert "[Temporary] Revert Implement winio.GetFileStandardInfo FileIn… 

    …fo commits "
    @katiewasnothere
    katiewasnothere authored Apr 22, 2021
    Configuration menu
    Copy the full SHA
    8f0d50b View commit details
    Browse the repository at this point in the history

  6. Merge pull request microsoft#209 from microsoft/revert-204-revert_fil… 

    …einfo_break

Revert removal of "Implement winio.GetFileStandardInfo FileInfo" commits
    @katiewasnothere
    katiewasnothere authored Apr 22, 2021
    Configuration menu
    Copy the full SHA
    58dba89 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Pull golang.org/x/sys v0.0.0-20210420205809-ac73e9fd8988 

    Specifically, this pulls the fix for
golang/go#44538
as we're going to start using this API in place of our own generated
wrapper.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
    @TBBle
    TBBle committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    323bd13 View commit details
    Browse the repository at this point in the history

  2. Use x/sys/windows for all windows constants 

    This replaces the use of either syscall or hard-coded magic numbers.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
    @TBBle
    TBBle committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    3415dd2 View commit details
    Browse the repository at this point in the history

  3. Flip Handle from syscall to windows, and everything changes 

    syscall.Handle is core to a _lot_ of structures and APIs, so this
great-big commit contains the entire rest of the conversion from syscall
to x/sys/windows.

I also eliminated a bunch of generated syscall wrappers which had
_direct_ equivalents in x/sys/windows. There's still a bunch which exist
in x/sys/windows and either have worse implementations, e.g.
windows.CreateFile, or somehow expose different APIs, e.g. the calls
used by privileges.go

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
    @TBBle
    TBBle committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    5188886 View commit details
    Browse the repository at this point in the history