Update submodule to latest master in microsoft/main

[microsoft-golang-bot]

Hi! I'm a bot, and this is an automatically generated upstream sync PR. 🔃

After submitting the PR, I will attempt to enable auto-merge in the "merge commit" configuration.

For more information, visit sync documentation in microsoft/go-infra.

[microsoft-golang-review-bot]

Thanks! Auto-approving.

[karianna]

Hmm, it seems this bot always auto approves even before CI has a chance to check things, should we change that behaviour?

[dagood]

Hmm, it seems this bot always auto approves even before CI has a chance to check things, should we change that behaviour?

Do you have some ideas why we might want to change it, or concerns?

[gdams]

Hmm, it seems this bot always auto approves even before CI has a chance to check things, should we change that behaviour?

Do you have some ideas why we might want to change it, or concerns?

I guess it might not be a bad idea to have it only approve it if all CI is green? It doesn't bother me that much though

[dagood]

I guess it might not be a bad idea to have it only approve it if all CI is green?

I don't think this behavior would be bad, but I also don't see any reason it would be better. I don't expect human reviewers to wait for CI to finish either.

[dagood]

CI failure is an upstream change: filed golang/go#68121.

[karianna]

I guess it might not be a bad idea to have it only approve it if all CI is green?

I don't think this behavior would be bad, but I also don't see any reason it would be better. I don't expect human reviewers to wait for CI to finish either.

I'll ask a different Q - what is the bot checking for before it gives the approval?

[dagood]

what is the bot checking for before it gives the approval?

It doesn't check anything. For context, microsoft-golang-review-bot and microsoft-golang-bot are separate accounts, but they are not independent in any way. A pipeline creates the PR with one account's PAT and (during the same command) uses the other account's PAT to approve it and turn on auto-merge. GitHub makes sure the CI passes before automerge goes ahead, because the branch is protected.

We have branch protection requiring a review approval--the goal is making dev PRs comfortable. The microsoft-golang-review-bot approvals are just a way to make auto-sync work without removing/bypassing branch protection.

[karianna]

what is the bot checking for before it gives the approval?

It doesn't check anything. For context, microsoft-golang-review-bot and microsoft-golang-bot are separate accounts, but they are not independent in any way. A pipeline creates the PR with one account's PAT and (during the same command) uses the other account's PAT to approve it and turn on auto-merge. GitHub makes sure the CI passes before automerge goes ahead, because the branch is protected.

We have branch protection requiring a review approval--the goal is making dev PRs comfortable. The microsoft-golang-review-bot approvals are just a way to make auto-sync work without removing/bypassing branch protection.

Cool, thanks for the context!