Skip to content

[microsoft/release-branch.go1.23] Update submodule for 1.23 #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

dagood
Copy link
Member

@dagood dagood commented Jul 24, 2024

No description provided.

@dagood dagood requested a review from a user July 24, 2024 18:42
@dagood dagood requested a review from a team as a code owner July 24, 2024 18:42
@gdams
Copy link
Member

gdams commented Jul 24, 2024

I see a test failure on windows

@dagood
Copy link
Member Author

dagood commented Jul 24, 2024

That's an interesting one... when testing with GOEXPERIMENT=cngcrypto in particular, telemetry isn't working (according to these test cases). Taking a look.

@dagood
Copy link
Member Author

dagood commented Jul 24, 2024

It repros upstream with $env:GOEXPERIMENT='aliastypeparams' (or anything else, it seems). Filing an issue.
(Edit: filed golang/go#68579)

@dagood
Copy link
Member Author

dagood commented Jul 25, 2024

For now, I added a patch to let the test case pass anyway, although the patch is specific to our CI case (cngcrypto).

@dagood dagood merged commit 4776637 into microsoft/release-branch.go1.23 Jul 25, 2024
23 checks passed
@dagood dagood deleted the dev/dagood/fork1.23 branch July 25, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants