Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer guide edits: rebase, cleanup, PRs, format #1420

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

dagood
Copy link
Member

@dagood dagood commented Nov 25, 2024

Formatting:

A few changes:

  • Mention git go-patch rebase.
  • Be more specific about cleanup--under what circumstances there's a risk if you don't clean up.
  • I don't think some of the text about patch files is necessary: patch files are explained early in the doc.
  • Add more info about PRs.

@dagood dagood requested a review from a team as a code owner November 25, 2024 18:40
Copy link
Contributor

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some minor comments.

eng/doc/DeveloperGuide.md Outdated Show resolved Hide resolved
eng/doc/DeveloperGuide.md Outdated Show resolved Hide resolved
eng/doc/DeveloperGuide.md Outdated Show resolved Hide resolved
@dagood dagood requested a review from qmuntal November 25, 2024 22:30
@dagood dagood merged commit 81b1559 into microsoft/main Nov 26, 2024
30 checks passed
@dagood dagood deleted the dev/dagood/dev-notes branch November 26, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants