Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule to latest master in microsoft/main #875

Merged

Conversation

microsoft-golang-bot
Copy link
Collaborator

Hi! I'm a bot, and this is an automatically generated upstream sync PR. 🔃

After submitting the PR, I will attempt to enable auto-merge in the "merge commit" configuration.

For more information, visit sync documentation in microsoft/go-infra.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Auto-approving.

@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch 4 times, most recently from 893428b to fd4f139 Compare February 22, 2023 16:02
@microsoft-golang-bot microsoft-golang-bot force-pushed the dev/auto-sync/microsoft/main branch 3 times, most recently from f1ede6a to e2d21d3 Compare March 1, 2023 16:07
@qmuntal
Copy link
Contributor

qmuntal commented Mar 3, 2023

The Windows pipelines are failing due to TestGdbPanic. I've sent an upstream fix for that: https://go-review.googlesource.com/c/go/+/473116.

We caught this issue because our builders have gdb installed, while upstream doesn't. IMO it makes sense to keep gdb, as hopefully upstream will install it in the near future: golang/go#22021.

@qmuntal
Copy link
Contributor

qmuntal commented Mar 6, 2023

There is another test failing, this time because our Windows builders have pkg-config but upstream don't, and there is a bug in how Go handles pkg-config flags. I just submitted a issue for that: golang/go#58889. Working on the fix.

@microsoft-golang-review-bot microsoft-golang-review-bot merged commit f687b92 into microsoft/main Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants