Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Code cleanup v1.0.0 blob_storage arguments #1538

Open
3 tasks done
intelligencecompany opened this issue Dec 19, 2024 · 1 comment
Open
3 tasks done

[Bug]: Code cleanup v1.0.0 blob_storage arguments #1538

intelligencecompany opened this issue Dec 19, 2024 · 1 comment
Labels
bug Something isn't working triage Default label assignment, indicates new issue needs reviewed by a maintainer

Comments

@intelligencecompany
Copy link
Contributor

intelligencecompany commented Dec 19, 2024

Do you need to file an issue?

  • I have searched the existing issues and this bug is not already filed.
  • My model is hosted on OpenAI or Azure. If not, please look at the "model providers" issue and don't file a new one here.
  • I believe this is a legitimate bug, not just a question. If this is a question, please use the Discussions area.

Describe the bug

The adjustment of the arguments is causing errors during indexing for the blob storage settings.

For example: #1482 line 39 (return create_blob_storage(**kwargs)). Where kwargs contains the property 'type', which is not expected by the function.

Ran into multiple locations, that this causes an error during indexing.

Steps to reproduce

#1482 line 39 (return create_blob_storage(**kwargs)).

Expected Behavior

Should be handled like:

def create_file_storage(**kwargs: Any) -> PipelineStorage:
        """Create a file based storage."""
        **base_dir = kwargs["base_dir"]**
        log.info("Creating file storage at %s", base_dir)
        return FilePipelineStorage(root_dir=base_dir)

GraphRAG Config Used

# Paste your config here

storage:
  type: blob # or blob
  base_dir: "output"
  connection_string: "${GRAPHRAG_STORAGE_CONNECTION_STRING}"
  storage_account_blob_url: "${GRAPHRAG_STORAGE_ACCOUNT_BLOB_URL}"
  container_name: "${GRAPHRAG_STORAGE_CONTAINER_NAME}"

Logs and screenshots

No response

Additional Information

@intelligencecompany intelligencecompany added bug Something isn't working triage Default label assignment, indicates new issue needs reviewed by a maintainer labels Dec 19, 2024
intelligencecompany added a commit to intelligencecompany/graphrag that referenced this issue Dec 19, 2024
intelligencecompany added a commit to intelligencecompany/graphrag that referenced this issue Dec 19, 2024
Second PR for issue microsoft#1538
@intelligencecompany
Copy link
Contributor Author

PR's #1539 and #1540 fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Default label assignment, indicates new issue needs reviewed by a maintainer
Projects
None yet
Development

No branches or pull requests

1 participant