Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Devtools): add css hightlight and dark theme #106

Merged
merged 7 commits into from
May 2, 2022
Merged

feat(Devtools): add css hightlight and dark theme #106

merged 7 commits into from
May 2, 2022

Conversation

YuanboXue-Amber
Copy link
Contributor

@YuanboXue-Amber YuanboXue-Amber commented Apr 26, 2022 •
edited
Loading

  • Highlight css with prismjs; matching the color with Edge devtools styles panel.
  • Added dark theme. Added story for dark themed FlattenView component
  • chore: bump eslint-plugin-react-hooks from 4.2.0 to 4.3.0, which has eslint 8 support. It fixes this error that I have while disabling react-hooks/exhaustive-deps

Screenshot 2022-05-02 at 17 06 43

Screenshot 2022-05-02 at 17 06 17

Screenshot 2022-04-26 at 13 55 30

Screenshot 2022-04-26 at 13 55 09

@github-actions
Copy link

github-actions bot commented Apr 26, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
core
makeStyles + mergeClasses (build time)		 1.8 kB
861 B
core
makeStyles + mergeClasses (runtime)		 20.269 kB
7.549 kB
react
makeStaticStyles (runtime)		 8.247 kB
3.595 kB
react
makeStyles + mergeClasses (runtime)		 21.294 kB
7.98 kB
react
makeStyles + mergeClasses (build time)		 2.811 kB
1.275 kB
🤖 This report was generated against 5b6cdf3ede6983eba5997b26f5696f2ea459606d

@YuanboXue-Amber YuanboXue-Amber marked this pull request as ready for review April 26, 2022 13:36
@YuanboXue-Amber YuanboXue-Amber requested a review from a team as a code owner April 26, 2022 13:36
@layershifter
Copy link
Member

image

nit: but let's fix it 🐱

@YuanboXue-Amber YuanboXue-Amber merged commit 03f45c8 into microsoft:main May 2, 2022
@YuanboXue-Amber YuanboXue-Amber deleted the devtools-hilight branch May 2, 2022 15:46
@YuanboXue-Amber
Copy link
Contributor Author

image

nit: but let's fix it 🐱

fixed on pairing :)

@YuanboXue-Amber YuanboXue-Amber mentioned this pull request May 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanboXue-Amber @layershifter