Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add export for __resetCSS #259

Merged
merged 1 commit into from
Oct 26, 2022
Merged

fix: add export for __resetCSS #259

merged 1 commit into from
Oct 26, 2022

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Oct 24, 2022 •
edited
Loading

Follow up for #250.

  • Fixes function name
  • Exports __resetCSS function

@github-actions
Copy link

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react
__css + mergeClasses (build time)		 1.879 kB
874 B
react
__styles + mergeClasses (build time)		 3.581 kB
1.614 kB
react
makeResetStyles (runtime)		 18.595 kB
6.981 kB
react
makeStaticStyles (runtime)		 9.443 kB
4.068 kB
react
makeStyles + mergeClasses (runtime)		 22.554 kB
8.436 kB
🤖 This report was generated against f8730b8d21573a94307458c9f313e64178fede94

layershifter
layershifter commented Oct 24, 2022
View reviewed changes
packages/react/src/__resetCSS.ts
@@ -7,7 +7,7 @@ import { useTextDirection } from './TextDirectionContext';
* @internal
*/
// eslint-disable-next-line @typescript-eslint/naming-convention
export function __resetStyles(ltrClassName: string, rtlClassName: string | null) {
export function __resetCSS(ltrClassName: string, rtlClassName: string | null) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@layershifter layershifter marked this pull request as ready for review October 24, 2022 15:27
@layershifter layershifter requested a review from a team as a code owner October 24, 2022 15:27
@layershifter layershifter merged commit d37c4b5 into microsoft:main Oct 26, 2022
@layershifter layershifter deleted the fix/rcss branch October 26, 2022 10:06
@layershifter layershifter mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsunderhus bsunderhus bsunderhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@layershifter @bsunderhus