Skip to content

Commit

Permalink
Add support for nodenetsvc v0 and readme to test network agent
Browse files Browse the repository at this point in the history
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
(cherry picked from commit 3955d35)
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
  • Loading branch information
katiewasnothere authored and kiashok committed Oct 13, 2023
1 parent bc73897 commit 23693bc
Show file tree
Hide file tree
Showing 4 changed files with 120 additions and 8 deletions.
23 changes: 23 additions & 0 deletions internal/tools/networkagent/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Using the test network agent

## Create a network agent configuration file
- Create a file named `nodenetsvc.conf` with the following contents:
```
{
"ttrpc": "\\\\.\\pipe\\ncproxy-ttrpc",
"grpc": "127.0.0.1:6669",
"node_net_svc_addr": "127.0.0.1:6668",
"timeout": 10,
"networking_settings": {
"hns_settings": {
"switch_name": "name-of-your-switch"
}
}
}
```
See definitions [here](https://github.com/microsoft/hcsshim/blob/main/internal/tools/networkagent/defs.go) for further customizing this configuration.
## Run the network agent
```
networkagent.exe --config .\nodenetsvc.conf
```
6 changes: 6 additions & 0 deletions internal/tools/networkagent/defs.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"os"

ncproxygrpc "github.com/Microsoft/hcsshim/pkg/ncproxy/ncproxygrpc/v1"
nodenetsvcV0 "github.com/Microsoft/hcsshim/pkg/ncproxy/nodenetsvc/v0"
"github.com/pkg/errors"
)

Expand All @@ -18,6 +19,11 @@ type service struct {
containerToNetwork map[string][]string
}

type v0ServiceWrapper struct {
s *service
nodenetsvcV0.UnimplementedNodeNetworkServiceServer
}

type hnsSettings struct {
SwitchName string `json:"switch_name,omitempty"`
IOVSettings *ncproxygrpc.IovEndpointPolicySetting `json:"iov_settings,omitempty"`
Expand Down
27 changes: 19 additions & 8 deletions internal/tools/networkagent/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"github.com/Microsoft/hcsshim/hcn"
"github.com/Microsoft/hcsshim/internal/log"
ncproxygrpc "github.com/Microsoft/hcsshim/pkg/ncproxy/ncproxygrpc/v1"
nodenetsvcV0 "github.com/Microsoft/hcsshim/pkg/ncproxy/nodenetsvc/v0"
nodenetsvc "github.com/Microsoft/hcsshim/pkg/ncproxy/nodenetsvc/v1"
"github.com/sirupsen/logrus"
"google.golang.org/grpc"
Expand Down Expand Up @@ -74,12 +75,17 @@ func generateIPs(prefixLength string) (string, string, string) {

func (s *service) configureHCNNetworkingHelper(ctx context.Context, req *nodenetsvc.ConfigureContainerNetworkingRequest) (_ *nodenetsvc.ConfigureContainerNetworkingResponse, err error) {
prefixIP, gatewayIP, midIP := generateIPs(strconv.Itoa(int(prefixLength)))

mode := ncproxygrpc.HostComputeNetworkSettings_NAT
if s.conf.NetworkingSettings.HNSSettings.IOVSettings != nil {
mode = ncproxygrpc.HostComputeNetworkSettings_Transparent
}
addNetworkReq := &ncproxygrpc.CreateNetworkRequest{
Network: &ncproxygrpc.Network{
Settings: &ncproxygrpc.Network_HcnNetwork{
HcnNetwork: &ncproxygrpc.HostComputeNetworkSettings{
Name: req.ContainerID + "_network_hcn",
Mode: ncproxygrpc.HostComputeNetworkSettings_Transparent,
Mode: mode,
SwitchName: s.conf.NetworkingSettings.HNSSettings.SwitchName,
IpamType: ncproxygrpc.HostComputeNetworkSettings_Static,
SubnetIpaddressPrefix: []string{prefixIP},
Expand All @@ -105,6 +111,11 @@ func (s *service) configureHCNNetworkingHelper(ctx context.Context, req *nodenet
return nil, err
}

policies := &ncproxygrpc.HcnEndpointPolicies{}
if s.conf.NetworkingSettings.HNSSettings.IOVSettings != nil {
policies.IovPolicySettings = s.conf.NetworkingSettings.HNSSettings.IOVSettings
}

name := req.ContainerID + "_endpoint_hcn"
endpointCreateReq := &ncproxygrpc.CreateEndpointRequest{
EndpointSettings: &ncproxygrpc.EndpointSettings{
Expand All @@ -115,9 +126,7 @@ func (s *service) configureHCNNetworkingHelper(ctx context.Context, req *nodenet
Ipaddress: midIP,
IpaddressPrefixlength: prefixLength,
NetworkName: network.Name,
Policies: &ncproxygrpc.HcnEndpointPolicies{
IovPolicySettings: s.conf.NetworkingSettings.HNSSettings.IOVSettings,
},
Policies: policies,
},
},
},
Expand Down Expand Up @@ -296,14 +305,14 @@ func (s *service) ConfigureContainerNetworking(ctx context.Context, req *nodenet

if req.RequestType == nodenetsvc.RequestType_Setup {
interfaces := []*nodenetsvc.ContainerNetworkInterface{}
if s.conf.NetworkingSettings.HNSSettings != nil {
if s.conf.NetworkingSettings != nil && s.conf.NetworkingSettings.HNSSettings != nil {
result, err := s.configureHCNNetworkingHelper(ctx, req)
if err != nil {
return nil, err
}
interfaces = append(interfaces, result.Interfaces...)
}
if s.conf.NetworkingSettings.NCProxyNetworkingSettings != nil {
if s.conf.NetworkingSettings != nil && s.conf.NetworkingSettings.NCProxyNetworkingSettings != nil {
result, err := s.configureNCProxyNetworkingHelper(ctx, req)
if err != nil {
return nil, err
Expand Down Expand Up @@ -435,8 +444,6 @@ func (s *service) ConfigureNetworking(ctx context.Context, req *nodenetsvc.Confi
return s.teardownHelper(ctx, req, containerNamespaceID)
}

// GetHostLocalIpAddress is defined in the nodenetworksvc proto which is owned by the azure vnetagent team
//
//nolint:stylecheck
func (s *service) GetHostLocalIpAddress(ctx context.Context, req *nodenetsvc.GetHostLocalIpAddressRequest) (*nodenetsvc.GetHostLocalIpAddressResponse, error) {
return &nodenetsvc.GetHostLocalIpAddressResponse{IpAddr: ""}, nil
Expand Down Expand Up @@ -484,8 +491,12 @@ func main() {
endpointToNicID: make(map[string]string),
containerToNetwork: make(map[string][]string),
}
v0Service := &v0ServiceWrapper{
s: service,
}
server := grpc.NewServer()
nodenetsvc.RegisterNodeNetworkServiceServer(server, service)
nodenetsvcV0.RegisterNodeNetworkServiceServer(server, v0Service)

grpcListener, err := net.Listen("tcp", conf.NodeNetSvcAddr)
if err != nil {
Expand Down
72 changes: 72 additions & 0 deletions internal/tools/networkagent/v0_service_wrapper.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
//go:build windows

package main

import (
"context"

"github.com/Microsoft/hcsshim/internal/log"
nodenetsvcV0 "github.com/Microsoft/hcsshim/pkg/ncproxy/nodenetsvc/v0"
nodenetsvc "github.com/Microsoft/hcsshim/pkg/ncproxy/nodenetsvc/v1"
)

func (s *v0ServiceWrapper) ConfigureContainerNetworking(ctx context.Context, req *nodenetsvcV0.ConfigureContainerNetworkingRequest) (_ *nodenetsvcV0.ConfigureContainerNetworkingResponse, err error) {
v1Req := &nodenetsvc.ConfigureContainerNetworkingRequest{
RequestType: nodenetsvc.RequestType(req.RequestType),
ContainerID: req.ContainerID,
NetworkNamespaceID: req.NetworkNamespaceID,
}
v1Resp, err := s.s.ConfigureContainerNetworking(ctx, v1Req)
if err != nil {
return nil, err
}

v0Interfaces := make([]*nodenetsvcV0.ContainerNetworkInterface, len(v1Resp.Interfaces))
for i, v1Interface := range v1Resp.Interfaces {
v0Interface := &nodenetsvcV0.ContainerNetworkInterface{
Name: v1Interface.Name,
MacAddress: v1Interface.MacAddress,
NetworkNamespaceID: v1Interface.NetworkNamespaceID,
}

if v1Interface.Ipaddresses != nil {
ipAddrs := make([]*nodenetsvcV0.ContainerIPAddress, len(v1Interface.Ipaddresses))
for i, v1IP := range v1Interface.Ipaddresses {
v0IP := &nodenetsvcV0.ContainerIPAddress{
Version: v1IP.Version,
Ip: v1IP.Ip,
PrefixLength: v1IP.PrefixLength,
DefaultGateway: v1IP.DefaultGateway,
}
ipAddrs[i] = v0IP
}
v0Interface.Ipaddresses = ipAddrs
}
v0Interfaces[i] = v0Interface
}
return &nodenetsvcV0.ConfigureContainerNetworkingResponse{
Interfaces: v0Interfaces,
}, nil
}

func (s *v0ServiceWrapper) ConfigureNetworking(ctx context.Context, req *nodenetsvcV0.ConfigureNetworkingRequest) (*nodenetsvcV0.ConfigureNetworkingResponse, error) {
log.G(ctx).WithField("req", req).Info("ConfigureNetworking request")
v1Req := &nodenetsvc.ConfigureNetworkingRequest{
ContainerID: req.ContainerID,
RequestType: nodenetsvc.RequestType(req.RequestType),
}
_, err := s.s.ConfigureNetworking(ctx, v1Req)
if err != nil {
return nil, err
}
return &nodenetsvcV0.ConfigureNetworkingResponse{}, nil
}

//nolint:stylecheck
func (s *v0ServiceWrapper) GetHostLocalIpAddress(ctx context.Context, req *nodenetsvcV0.GetHostLocalIpAddressRequest) (*nodenetsvcV0.GetHostLocalIpAddressResponse, error) {
return &nodenetsvcV0.GetHostLocalIpAddressResponse{IpAddr: ""}, nil
}

func (s *v0ServiceWrapper) PingNodeNetworkService(ctx context.Context, req *nodenetsvcV0.PingNodeNetworkServiceRequest) (*nodenetsvcV0.PingNodeNetworkServiceResponse, error) {
return &nodenetsvcV0.PingNodeNetworkServiceResponse{}, nil
}

0 comments on commit 23693bc

Please sign in to comment.