Adding stringer for usage and CI/CD

Signed-off-by: ritikaguptams <85255050+ritikaguptams@users.noreply.github.com> Fixing build errors Signed-off-by: ritikaguptams <85255050+ritikaguptams@users.noreply.github.com> Ignore linting for files generated by Stringer Signed-off-by: ritikaguptams <85255050+ritikaguptams@users.noreply.github.com> Trying to fix CI go gen Signed-off-by: ritikaguptams <85255050+ritikaguptams@users.noreply.github.com> Removing extra step to fix CI go gen Signed-off-by: ritikaguptams <85255050+ritikaguptams@users.noreply.github.com> go gen CI fix try 2 Signed-off-by: ritikaguptams <85255050+ritikaguptams@users.noreply.github.com> Skip autogenerated file from linting Signed-off-by: ritikaguptams <85255050+ritikaguptams@users.noreply.github.com> Fixing linting Signed-off-by: ritikaguptams <85255050+ritikaguptams@users.noreply.github.com>
microsoft · Jun 20, 2024 · c193dae · c193dae
1 parent 81ea36e
commit c193dae
Show file tree

Hide file tree

Showing 49 changed files with 11,832 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -217,6 +217,12 @@ jobs:
  go.sum
  test/go.sum
 
+ Install Stringer
+ - name: Install stringer
+ run: |
+ go install golang.org/x/tools/cmd/stringer@latest
+ echo "${{ runner.os }}-latest" >> $GITHUB_PATH
+ 
  - name: Pre-fill Module Cache
  shell: powershell
  run: |
@@ -348,7 +354,7 @@ jobs:
 
  # accept the eula
  & '${{ github.workspace }}/bin/psexec' -accepteula -nobanner cmd /c "exit 0" 2>$null
-
+ 
  # run tests
  - name: Test repo
  run: ${{ env.GOTESTSUM_CMD }} -gcflags=all=-d=checkptr -tags admin -timeout=20m ./...

diff --git a/.golangci.yml b/.golangci.yml
@@ -171,4 +171,4 @@ issues:
  - path: internal\\vhdx\\info
  linters:
  - stylecheck
- Text: "ST1003:"
+ Text: "ST1003:"
diff --git a/go.mod b/go.mod
@@ -36,6 +36,7 @@ require (
  go.uber.org/mock v0.4.0
  golang.org/x/sync v0.7.0
  golang.org/x/sys v0.21.0
+ golang.org/x/tools v0.15.0
  google.golang.org/grpc v1.64.0
  google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.4.0
  google.golang.org/protobuf v1.34.2
@@ -110,7 +111,6 @@ require (
  golang.org/x/mod v0.14.0 // indirect
  golang.org/x/net v0.25.0 // indirect
  golang.org/x/text v0.15.0 // indirect
- golang.org/x/tools v0.15.0 // indirect
  google.golang.org/genproto v0.0.0-20240227224415-6ceb2ff114de // indirect
  google.golang.org/genproto/googleapis/rpc v0.0.0-20240318140521-94a12d6c2237 // indirect
  gopkg.in/yaml.v2 v2.4.0 // indirect

diff --git a/internal/hns/endpointstate_string.go → internal/hns/endpointstate_string_windows.go b/internal/hns/endpointstate_string.go → internal/hns/endpointstate_string_windows.go
diff --git a/internal/hns/hnsendpoint.go b/internal/hns/hnsendpoint.go
@@ -10,13 +10,13 @@ import (
  "github.com/sirupsen/logrus"
 )
 
-//go:generate stringer -type=EndpointState
+//go:generate go run golang.org/x/tools/cmd/stringer -type=EndpointState -output=endpointstate_string_windows.go -trimprefix=EndpointState -tags=windows
 
 // EndpointState represents the states of an HNS Endpoint lifecycle.
 type EndpointState uint16
 
 // EndpointState const
-// The lifecycle of an Endpoint goes through created, attached, being shared with other containers,
+// The lifecycle of an Endpoint goes through created, attached, AttachedSharing - endpoint is being shared with other containers,
 // detached, after being attached, degraded and finally destroyed.
 const (
  Uninitialized EndpointState = iota

diff --git a/tools/tools.go b/tools/tools.go
@@ -20,4 +20,7 @@ import (
 
  // mock gRPC client and servers
  _ "go.uber.org/mock/mockgen"
+
+ // used in enum to string conversions
+ _ "golang.org/x/tools/cmd/stringer"
 )