Skip to content

Commit

Permalink
Clarifying SVN vs. Version.
Browse files Browse the repository at this point in the history
This commit updates `framework_svn` and `api_svn` to be named `framework_version` and `api_version`,
respectively. The original names were to represent a *semantic* version number, which was confusing
in this context where SVN more commonly means *security* version number. Accordingly, the
`minimum_svn` and `svn` fields for fragments will remain with the existing naming scheme but their
support has been expanded to allow these strings to also be monotonically increasing integers, to
be more in line with expectations around SVNs.

To provide a smooth transition, support for semantically versioned fragments and the `*_svn` naming
scheme remain in the framework, but in a deprecated state. As part of this, the policy engline will
provide a new error when the type of SVN is different between the SVN of the fragment and the
`minimum_svn` property of a fragment policy object: `fragment svn and the specified minimum are different types`.

Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
  • Loading branch information
matajoh committed Mar 29, 2023
1 parent e7b0eab commit d8886a4
Show file tree
Hide file tree
Showing 20 changed files with 1,469 additions and 447 deletions.
3 changes: 2 additions & 1 deletion internal/cosesign1/infra.rego
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package infra

svn := "1.0.0"
svn := "1"
framework_version := "0.1.0"

containers := [
{
Expand Down
4 changes: 2 additions & 2 deletions internal/tools/policyenginesimulator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ for more detail.
``` rego
package policy
api_svn := "0.7.0"
api_version := "0.7.0"
import future.keywords.every
import future.keywords.in
Expand Down Expand Up @@ -187,7 +187,7 @@ reason := {"errors": data.framework.errors}
``` rego
package policy
api_svn := "0.7.0"
api_version := "0.7.0"
overlays := {
"pause": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package policy

api_svn := "0.7.0"
api_version := "0.7.0"

overlays := {
"pause": {
Expand Down
Loading

0 comments on commit d8886a4

Please sign in to comment.