Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support for storage space data disks" #1035

Closed
wants to merge 1 commit into from

Conversation

ambarve
Copy link
Contributor

@ambarve ambarve commented May 20, 2021

Reverts #998

Not sure how this got merged. I must have merged this by mistake while trying to merge the other PR #1021

@ambarve ambarve requested a review from a team as a code owner May 20, 2021 17:55
@ambarve
Copy link
Contributor Author

ambarve commented May 20, 2021

I am pretty sure I never merged this PR and there is no need to revert it. When I was making changes for #1021 I made them on the same branch (storage_spaces) by rebasing it locally and then I pushed the new commit to a new branch (scsi_vsmb_fix) and also pushed this (storage_spaces) branch and changed this PR to draft because I still wanted to push new changes here. However, it looks like github automatically changed the status of this PR from draft to merged when I merged #1021 because both of these branches have the same commit at top. The diff of this merged PR only shows changes that are exactly the same as #1021 so there is no need to revert anything.

I guess if I push new changes to storage_spaces branch then github might automatically change the status of that PR back to open or if not I can open another PR.

@ambarve ambarve closed this May 20, 2021
@ambarve ambarve deleted the revert-998-storage_spaces branch May 20, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants