-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test network agent for ncproxy dev work #1067
Add test network agent for ncproxy dev work #1067
Conversation
@dcantah in particular :) |
One note: I would probably put this under |
Thanks for making this btw ❤️ I'll keep the review up on Monday |
I'm wondering how we could make some useful tests here.. We need to launch ncproxy and the test agent and make calls between them to have anything of value |
c4cd8fc
to
5beee2f
Compare
@dcantah I was planning for this to mostly be useful for devs when manually testing. I'm still trying to figure out how we should write tests for ncproxy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Don't think we need to hold off on this for much, think you'd rather have it in already. Misc. cleanup, some better signal handling, and some os.Exit removals that I'd like to see, but the rest looks fine (just push new commit and squash on check in and we're all good). Had a small q on an a new nns call that's added here also that I'd like an answer on.
46c347b
to
3054463
Compare
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
3054463
to
2d0978c
Compare
re-lgtm |
Related work items: microsoft#1067, microsoft#1097, microsoft#1119, microsoft#1170, microsoft#1176, microsoft#1180, microsoft#1181, microsoft#1182, microsoft#1183, microsoft#1184, microsoft#1185, microsoft#1186, microsoft#1187, microsoft#1188, microsoft#1189, microsoft#1191, microsoft#1193, microsoft#1194, microsoft#1195, microsoft#1196, microsoft#1197, microsoft#1200, microsoft#1201, microsoft#1202, microsoft#1203, microsoft#1204, microsoft#1205, microsoft#1206, microsoft#1207, microsoft#1209, microsoft#1210, microsoft#1211, microsoft#1218, microsoft#1219, microsoft#1220, microsoft#1223
This PR contains a test version of a vnetagent that we can use locally when doing dev work with ncproxy. This is not meant to be used outside of a testing environment.
This PR additionally updates cmd/ncproxy/nodenetsvc/nodenetsvc.proto to match the current version being used by the AzNet team.
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com