Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dm-verity for multi-mapped LCOW layers #1089

Merged
merged 2 commits into from
Sep 4, 2021

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Jul 29, 2021

Previously dm-verity was enabled only for dedicated VPMems. This
change adds dm-verity footer parsing logic to multi-mapped LCOW
layers

Signed-off-by: Maksim An maksiman@microsoft.com

@anmaxvl anmaxvl requested a review from a team as a code owner July 29, 2021 08:50
@anmaxvl anmaxvl force-pushed the multi-mapping-dm-verity branch from 7e80a30 to 04a79ed Compare August 10, 2021 23:53
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small request, otherwise LGTM

@anmaxvl anmaxvl force-pushed the multi-mapping-dm-verity branch from 04a79ed to 7c6c0b7 Compare August 11, 2021 00:46
Previously dm-verity was enabled only for dedicated VPMems. This
change adds dm-verity footer parsing logic to multi-mapped LCOW
layers

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl force-pushed the multi-mapping-dm-verity branch from 7c6c0b7 to 133ed7f Compare August 11, 2021 16:27
@anmaxvl anmaxvl changed the title enable dm-verity for multi-mapped LCOW layers Enable dm-verity for multi-mapped LCOW layers Aug 11, 2021
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SeanTAllen
Copy link
Contributor

@anmaxvl anything preventing this from being merged?

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl merged commit 6e21887 into microsoft:master Sep 4, 2021
@anmaxvl anmaxvl deleted the multi-mapping-dm-verity branch September 4, 2021 00:43
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
Previously dm-verity was enabled only for dedicated VPMems. This
change adds dm-verity footer parsing logic to multi-mapped LCOW
layers

Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants