Fix ReadDMVeritySuperBlock function #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure to assert the value of dmveritySuperblock.Signature before trying to read the root hash, without the check, any valid footer would be treated as a dm-verity superblock. Add unit tests to cover other edge cases. Signed-off-by: Maksim An <maksiman@microsoft.com>
dcantah
reviewed
Dec 29, 2021
In some places when returning an error from ReadDMVeritySuperBlock, a custom error was wrapped, rather than the original error, which complicates assertions with errors.Cause/errors.Unwrap. Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
fix-read-dmverity-superblock
branch
from
4ad4603
to
04bf58a
Compare
dcantah
reviewed
Jan 4, 2022
dcantah
approved these changes
Jan 4, 2022
Signed-off-by: Maksim An <maksiman@microsoft.com>
|
Assigned myself here #1258 and assigned you to this PR, might as well as they're both some what in the same realm 😝 |
katiewasnothere
approved these changes
Jan 13, 2022
Signed-off-by: Maksim An <maksiman@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Make sure to assert the value of dmveritySuperblock.Signature before trying to read the root hash. Without the check, any valid footer with with valid size would be treated as a dm-verity superblock. Additionally wrap original Read errors, rather than custom errors. In some places when returning an error from ReadDMVeritySuperBlock, a custom error was wrapped, rather than the original error, which complicates assertions with errors.Cause/errors.Unwrap. Add unit tests to cover other edge cases. Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to assert the value of dmveritySuperblock.Signature before
trying to read the root hash, without the check, any valid footer would
be treated as a dm-verity superblock.
Add unit tests to cover other edge cases.
Signed-off-by: Maksim An maksiman@microsoft.com