Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unsafe container options #1260

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Commits on Feb 10, 2022

  1. Option to disable adding writable shares

    Added annotation to disable adding writable vSMB or plan 9 file shares
    to a UVM.
    
    Grouped together setting common *COW options into a common function to
    improve readability.
    
    Added tests for proper initialization and processing of common creation
    options, as well as functional tests for disabling writable shares.
    Currently, functional tests do not run smoothly.
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    04537d7 View commit details
    Browse the repository at this point in the history
  2. Disabled gMSA via annotation

    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    861d013 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. PR: tests, annotation expansion, naming, creation options

    Can now expand an annotation into several sub annotations to toggle
    groups of features on and off. Added tests for this as well.
    
    Moved general annotation handling and parsing from `internal/oci/uvm.go`
    to `internal/oci/annotations`, and updated tests.
    
    Combined common OCI and gMSA tests together with subtests
    Made capitalization for GMSA consistent throughout.
    
    Removed changes to test/functional/utilities
    
    Removed unnecessary error return.
    
    Removed creation option for disabling gMSA and instead parse the
    annotation directly from the spec.
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    51ecc1b View commit details
    Browse the repository at this point in the history