Add ErrInvalidHandle and fix list stats #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
force-pushed
the
handle-error-invalid-handle
branch
from
de11d2d to
9fa829e
Compare
When querying the stats of a container that is in the process of being stopped, an ERROR_INVALID_HANDLE (0x6) may be returned. This change ignores that error and returns an empty stats object. This change also fixes the return values of Stats() when encountering one of the expected errors. Returning nil stats when error is nil will break caller assumptions of finding a valid value when error is nil. Instead, an ErrNotFound is returned. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
handle-error-invalid-handle
branch
from
9fa829e to
8420138
Compare
dcantah
approved these changes
Jan 13, 2022
This was referenced Jan 13, 2022
helsaawy
approved these changes
Jan 13, 2022
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Jan 13, 2022
When querying the stats of a container that is in the process of being stopped, an ERROR_INVALID_HANDLE (0x6) may be returned. This change ignores that error and returns an empty stats object. This change also fixes the return values of Stats() when encountering one of the expected errors. Returning nil stats when error is nil will break caller assumptions of finding a valid value when error is nil. Instead, an ErrNotFound is returned. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com> (cherry picked from commit 790bcae) Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
added a commit
that referenced
this pull request
Jan 13, 2022
When querying the stats of a container that is in the process of being stopped, an ERROR_INVALID_HANDLE (0x6) may be returned. This change ignores that error and returns an empty stats object. This change also fixes the return values of Stats() when encountering one of the expected errors. Returning nil stats when error is nil will break caller assumptions of finding a valid value when error is nil. Instead, an ErrNotFound is returned. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com> (cherry picked from commit 790bcae) Signed-off-by: Daniel Canter <dcanter@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
When querying the stats of a container that is in the process of being stopped, an ERROR_INVALID_HANDLE (0x6) may be returned. This change ignores that error and returns an empty stats object. This change also fixes the return values of Stats() when encountering one of the expected errors. Returning nil stats when error is nil will break caller assumptions of finding a valid value when error is nil. Instead, an ErrNotFound is returned. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying the stats of a container that is in the process of beingstopped, an ERROR_INVALID_HANDLE (0x6) may be returned. This change ignores that error as part of
isStatsNotFound().This change also fixes the return values of Stats() when encountering one of the expected errors. Returning nil stats when error is nil will break caller assumptions of finding a valid value when error is nil. Instead, we now return an
ErrNotFound.Signed-off-by: Gabriel Adrian Samfira gsamfira@cloudbasesolutions.com