Update securitypolicy struct names and docstrings #1278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SeanTAllen FYI |
anmaxvl
force-pushed
the
security-policy-updates
branch
from
10aa780 to
be74c28
Compare
|
I think while making this change, we should seriously consider changing the name "SecurityPolicy". The issue with "security policy" that I've found is that people assume there's something "active" that is going on. And in a way there is, but not how the word leads people to imagine it. What we are doing really is taking a wide-open environment and constraining it to only allow what the user has indicated should happen. It is a subtle but important difference. That said, I do not have a better idea at the moment for a name. |
During initial implementation a few things were skipped and the plan was to address them later. Some of the things include missing docstrings on exported security policy structs, methods and interfaces. This PR addresses above by splitting existing comments on the Policy struct and putting them closer to the actual implementation. Additionally fix inconsistencies with typical golang naming conventions. Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
force-pushed
the
security-policy-updates
branch
from
be74c28 to
023e7dd
Compare
|
As mentioned in PR description, wait until #1279 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During initial implementation a few things were skipped and the
plan was to address them later. Some of the things include missing
docstrings on exported security policy structs, methods and
interfaces.
This PR addresses above by splitting existing comments on the
Policy struct and putting them closer to the actual implementation.
Additionally fix inconsistencies with typical golang naming
conventions.
Signed-off-by: Maksim An maksiman@microsoft.com