Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin go version for linter to 1.17.x #1346

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Pin go version for linter to 1.17.x #1346

merged 1 commit into from
Apr 7, 2022

Commits on Apr 7, 2022

  1. Pin go version for linter to 1.17.x

    Some of the tooling golangci-lint uses doesn't fully support 1.18 yet
    resulting in a bunch of hard to decode errors. We were using ^1.17.0
    as our version listed so we ended up resolving to 1.18 a couple of days
    ago and finally ran into this. v1.45.0 of golangci-lint has a
    workaround for this which is disabling some of the problematic linters,
    but these are some of our most used. This seems like a sane fix for
    now until the kinks are worked out and things are working on 1.18.
    
    Signed-off-by: Daniel Canter <dcanter@microsoft.com>
    dcantah committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    e9c507d View commit details
    Browse the repository at this point in the history