Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge rpcProc string conversion #1391

Merged
merged 1 commit into from
May 9, 2022

Conversation

helsaawy
Copy link
Contributor

@helsaawy helsaawy commented May 9, 2022

Factored internal/gcs.(rpcProc).String() method out from internal/gcs.(msgType).String()

This is needed for PR #1379

Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
@helsaawy helsaawy requested a review from a team as a code owner May 9, 2022 17:36
Copy link
Contributor

@ambarve ambarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@helsaawy helsaawy merged commit ebe034c into microsoft:master May 9, 2022
@helsaawy helsaawy deleted the he/bridge-string branch May 9, 2022 19:29
anmaxvl added a commit that referenced this pull request Feb 7, 2023
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants