Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcs: Add SCSIDevice type with remove operation #1741

Merged
merged 1 commit into from
May 3, 2023

Commits on May 3, 2023

  1. gcs: Add SCSIDevice type with remove operation

    SCSI devices must be unplugged by the guest before removal on the host
    side, to ensure smooth operation. Previously a SCSI device was unplugged
    when a LCOWMappedVirtualDisk entry was removed. However, we want to
    support multiple mounts per disk, which means we need to decouple unplug
    from unmount.
    
    This change introduces a new SCSIDevice resource type that has a remove
    operation that can be used by the host to trigger an explicit unplug via
    SCSI.
    
    This is a breaking change to the bridge protocol:
    - With new host/old guest, the host will attempt a SCSIDevice remove
      which will fail due to being unsupported by the guest.
    - With old host/new guest, the host will expect the device to be
      unplugged when the disk is removed, which will no longer occur.
    
    Signed-off-by: Kevin Parsons <kevpar@microsoft.com>
    kevpar committed May 3, 2023
    Configuration menu
    Copy the full SHA
    cbe5c33 View commit details
    Browse the repository at this point in the history