Minor fixes to SCSI mount operation #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
approved these changes
Jun 2, 2023
anmaxvl
approved these changes
Jun 2, 2023
During a recent refactor SCSI mount operation code removed a retry logic that is needed when examining the filesystem type on a SCSI device. Retry is needed because sometimes attempting to open a SCSI devices immediately after attaching it results in ENXIO/ENOENT errors. This adds the retry logic back. Names of some images used in the tests had changed, this commit updates those names too. Signed-off-by: Amit Barve <ambarve@microsoft.com>
anmaxvl
pushed a commit
that referenced
this pull request
Oct 20, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
During a recent refactor SCSI mount operation code removed a retry logic that is needed when examining the filesystem type on a SCSI device. Retry is needed because sometimes attempting to open a SCSI devices immediately after attaching it results in ENXIO/ENOENT errors. This adds the retry logic back. Names of some images used in the tests had changed, this commit updates those names too. Signed-off-by: Amit Barve <ambarve@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a recent refactor SCSI mount operation code removed a retry logic that is needed when examining the filesystem type on a SCSI device. Retry is needed because sometimes attempting to open a SCSI devices immediately after attaching it results in ENXIO/ENOENT errors. This adds the retry logic back.
Names of some images used in the tests had changed, this commit updates those names too.