Version control and vendor mockgen #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly track `github.com/golang/mock/mockgen` as a go dependency. (There is no change in our go.mod or go.sum, since the package is already being used by the generated code and elsewhere). Add `//go:generate` directives to create the mocked files and ensure the results are always up to date. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
katiewasnothere
approved these changes
Jun 5, 2023
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Oct 11, 2023
Explicitly track `github.com/golang/mock/mockgen` as a go dependency. (There is no change in our go.mod or go.sum, since the package is already being used by the generated code and elsewhere). Add `//go:generate` directives to create the mocked files and ensure the results are always up to date. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> (cherry picked from commit 61e0112) Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Oct 11, 2023
Explicitly track `github.com/golang/mock/mockgen` as a go dependency. (There is no change in our go.mod or go.sum, since the package is already being used by the generated code and elsewhere). Add `//go:generate` directives to create the mocked files and ensure the results are always up to date. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> (cherry picked from commit 61e0112) Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
kiashok
pushed a commit
to kiashok/hcsshim
that referenced
this pull request
Oct 11, 2023
Explicitly track `github.com/golang/mock/mockgen` as a go dependency. (There is no change in our go.mod or go.sum, since the package is already being used by the generated code and elsewhere). Add `//go:generate` directives to create the mocked files and ensure the results are always up to date. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> (cherry picked from commit 61e0112) Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
kiashok
pushed a commit
that referenced
this pull request
Oct 13, 2023
Explicitly track `github.com/golang/mock/mockgen` as a go dependency. (There is no change in our go.mod or go.sum, since the package is already being used by the generated code and elsewhere). Add `//go:generate` directives to create the mocked files and ensure the results are always up to date. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> (cherry picked from commit 61e0112) Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
anmaxvl
pushed a commit
that referenced
this pull request
Oct 20, 2023
KenGordon
pushed a commit
to KenGordon/hcsshim
that referenced
this pull request
May 17, 2024
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Explicitly track `github.com/golang/mock/mockgen` as a go dependency. (There is no change in our go.mod or go.sum, since the package is already being used by the generated code and elsewhere). Add `//go:generate` directives to create the mocked files and ensure the results are always up to date. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly track
github.com/golang/mock/mockgenas a go dependency. (There is no change in our go.mod or go.sum, since the package is already being used by the generated code and elsewhere).Add
//go:generatedirectives to create the mocked files and ensure the results are always up to date.