Add deprecated option to all types and fields for ncproxy v0 apis #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
…ted ncproxy api use Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
katiewasnothere
force-pushed
the
kabaldau/ncproxy_v0_deprecated_tag
branch
from
1f6009c to
46d8160
Compare
helsaawy
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the v0 api for ncproxygrpc and nodenetsvc with deprecated options on all message types and their fields. The goal of this change is to make it as apparent as possible that the v0 APIs are deprecated and callers should move to the v1 APIs.
According to the protobuf spec here, the deprecated option in most languages has no effect, though some languages it will produce compiler warnings.
This PR additionally updates the golangci.yml to ignore linter errors due to referencing the deprecated apis in cmd/ncproxy and tests.