Fix mountSCSI failure in uvmboot #1841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Wright <t-willwright@microsoft.com>
|
Closed as according to #1744 (comment) this is intended behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the mount logic inside the
mountSCSIfunction of uvmboot, which is called when attaching SCSI disks to the guest.Passing an empty
MountConfigtoAddVirtualDiskcauses an error on the add operation inside the guest. As specified in theAddVirtualDiskdocumentation,nilshould be passed instead to signify that no mount operation should be performed.Currently, the guest mount operation is disallowed in
mountSCSI, so it is not necessary to create aMountConfigto pass toAddVirtualDiskin that case.