Add more go vet checks #1849
Merged
Add more go vet checks #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambarve
reviewed
Aug 9, 2023
ambarve
reviewed
Aug 9, 2023
| @@ -250,7 +250,7 @@ func (s *service) teardownConfigureContainerNetworking(ctx context.Context, req | |||
|
|
|||
| for _, endpoint := range resp.Endpoints { | |||
| if endpoint == nil { | |||
| log.G(ctx).WithField("name", endpoint.ID).Warn("failed to find endpoint to delete") | |||
| log.G(ctx).Warn("failed to find endpoint to delete") | |||
There was a problem hiding this comment.
Just curious, is it possible to receive nil endpoints in a valid response from ncproxy?
There was a problem hiding this comment.
I'm not too sure, but I think absent a guarantee of such, the nil-check and logging is probably worth keeping.
@katiewasnothere, thought?
There was a problem hiding this comment.
I don't think it's possible but also this is just a test tool so I don't think we need to worry too much either way.
ambarve
reviewed
Aug 9, 2023
ambarve
approved these changes
Aug 9, 2023
Turn on all [go vet](https://pkg.go.dev/cmd/vet) checks (except for `fieldalignment`, and ignore shadowing `err` variables. Caught a couple minor bugs: - ncproxy did not set the panic file for the service - `nil`-field access in logs - not updating `processorLimits` in `(*UtilityVM).Update` Simplified a couple `if` statements clauses where [conditional evaluation](https://go.dev/ref/spec#Logical_operators) made `!= nil` checks redundant. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
katiewasnothere
approved these changes
Aug 17, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
* Enable all go vet checks Turn on all [go vet](https://pkg.go.dev/cmd/vet) checks (except for `fieldalignment`, and ignore shadowing `err` variables. Caught a couple minor bugs: - ncproxy did not set the panic file for the service - `nil`-field access in logs - not updating `processorLimits` in `(*UtilityVM).Update` Simplified a couple `if` statements clauses where [conditional evaluation](https://go.dev/ref/spec#Logical_operators) made `!= nil` checks redundant. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> * PR: err name; decl Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> --------- Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on all go vet checks (except for
fieldalignmentand ignore shadowingerrvariables.Caught a couple minor bugs:
nil-field access in logsprocessorLimitsin(*UtilityVM).UpdateSimplified a couple
ifstatements clauses where conditional evaluation made!= nilchecks redundant.