Embed version info; print benchmark config #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update how we set/read the version and commit information, so that it can be set via writing to files instead of needing to update all `go build` commands to add (or update) `-ldflags` with `-X main.version=... -X manin.gitCommit=...". Augment benchmark configuration with additional information, such as the go version, number of CPUs available, start time, version, and git branch and commit. This allows standardizing the configuration data across different benchmarking suites. Benchmark config follow the benchmark raw data format: https://go.googlesource.com/proposal/+/master/design/14313-benchmark-format.md Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
approved these changes
Sep 6, 2023
katiewasnothere
approved these changes
Oct 23, 2023
darracott
pushed a commit
to KenGordon/hcsshim
that referenced
this pull request
Oct 30, 2023
Update how we set/read the version and commit information, so that it can be set via writing to files instead of needing to update all `go build` commands to add (or update) `-ldflags` with `-X main.version=... -X manin.gitCommit=...". Augment benchmark configuration with additional information, such as the go version, number of CPUs available, start time, version, and git branch and commit. This allows standardizing the configuration data across different benchmarking suites. Benchmark config follow the benchmark raw data format: https://go.googlesource.com/proposal/+/master/design/14313-benchmark-format.md Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> Signed-off-by: Joe Powell <joepowell@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Update how we set/read the version and commit information, so that it can be set via writing to files instead of needing to update all `go build` commands to add (or update) `-ldflags` with `-X main.version=... -X manin.gitCommit=...". Augment benchmark configuration with additional information, such as the go version, number of CPUs available, start time, version, and git branch and commit. This allows standardizing the configuration data across different benchmarking suites. Benchmark config follow the benchmark raw data format: https://go.googlesource.com/proposal/+/master/design/14313-benchmark-format.md Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update how we set/read the version and commit information, so that it can be set via writing to files instead of needing to update all
go buildcommands to add (or update)-ldflagswith-X main.version=... -X main.gitCommit=...".Augment benchmark configuration with additional information, such as the go version, number of CPUs available, start time, version, and git branch and commit.
This allows standardizing the configuration data across different benchmarking suites (including future, non-go based suites).
Benchmark config follows the benchmark raw data format: https://golang.org/design/14313-benchmark-format