Skip shim tests if shim binary is not found #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than failing tests when attempting to exec the shim executable, look up its path first and skip if it is not found. Most testing binaries require that other binaries be located in the same directory as them (see `require.Binary`), but since the CI runs the shim tests directly, add `require.BinaryInPath`, which looks for the binary in the path or current working directory first. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
approved these changes
Sep 8, 2023
helsaawy
added a commit
to helsaawy/hcsshim
that referenced
this pull request
Sep 20, 2023
Backport testing support functions in the `test/pkg` directory. This includes changes from: - microsoft#1536 - microsoft#1704 - microsoft#1853 - microsoft#1893 Rather than cherry-pick them, only changes to `test/pkg` are included, since tests themselves will require significant changes to bring up-to-date. The goal is to expose testing functions so that tests can be moved out of the repo. Updated go version in `test` to 1.8, as required by `test/pkg/flag`. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
added a commit
to helsaawy/hcsshim
that referenced
this pull request
Sep 27, 2023
Rather than failing tests when attempting to exec the shim executable, look up its path first and skip if it is not found. Most testing binaries require that other binaries be located in the same directory as them (see `require.Binary`), but since the CI runs the shim tests directly, add `require.BinaryInPath`, which looks for the binary in the path or current working directory first. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
added a commit
that referenced
this pull request
Sep 28, 2023
Backport testing support functions in the `test/pkg` directory. This includes changes from: - #1536 - #1704 - #1853 - #1893 Rather than cherry-pick them, only changes to `test/pkg` are included, since tests themselves will require significant changes to bring up-to-date. The goal is to expose testing functions so that tests can be moved out of the repo. Updated go version in `test` to 1.8, as required by `test/pkg/flag`. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than failing tests when attempting to exec the shim executable, look up its path first and skip if it is not found.
Most testing binaries require that other binaries be located in the same directory as them (see
require.Binary), but since the CI runs the shim tests directly, addrequire.BinaryInPath, which looks for the binary in the path or current working directory first.