Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/0.11 backport] [ci] Fix integration test failure #1909

Closed

Conversation

thaJeztah
Copy link
Contributor

(cherry picked from commit f5c5797)

@thaJeztah thaJeztah requested a review from a team as a code owner September 18, 2023 17:54
@thaJeztah
Copy link
Contributor Author

@thaJeztah thaJeztah mentioned this pull request Sep 18, 2023
@thaJeztah
Copy link
Contributor Author

@helsaawy @kevpar looks like CI needs approval first 😅

@thaJeztah
Copy link
Contributor Author

thaJeztah commented Sep 18, 2023

One failure on Window-2022; I guess not related to this PR, is that a known flaky test?

=== Failed
=== FAIL: internal/exec TestExecStdinPowershell (10.00s)
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Install the latest PowerShell for new features and improvements! https://aka.ms/PSWindows

PS D:\a\hcsshim\hcsshim\internal\exec> ping 127.0.0.1

Pinging 127.0.0.1 with 32 bytes of data:
Reply from 127.0.0.1: bytes=32 time<1ms TTL=128
Reply from 127.0.0.1: bytes=32 time<1ms TTL=128
Reply from 127.0.0.1: bytes=32 time<1ms TTL=128
Reply from 127.0.0.1: bytes=32 time<1ms TTL=128

Ping statistics for 127.0.0.1:
    Packets: Sent = 4, Received = 4, Lost = 0 (0% loss),
Approximate round trip times in milli-seconds:
    Minimum = 0ms, Maximum = 0ms, Average = 0ms
PS D:\a\hcsshim\hcsshim\internal\exec> exit
    exec_test.go:123: timed out waiting for process to complete

And build failures in one part, because it looks like it depends on a version of containerd that requires go1.21;

go build  -gcflags=-trimpath=D/src  -o bin/ctr.exe -ldflags '-X github.com/containerd/containerd/version.Version=82df7d5 -X github.com/containerd/containerd/version.Revision=82df7d52086e1e39d7b56819d89ea75eab5eb9fd -X github.com/containerd/containerd/version.Package=github.com/containerd/containerd -s -w ' -tags "urfave_cli_no_docs"  ./cmd/ctr
+ bin/containerd.exe
go build  -gcflags=-trimpath=D/src  -o bin/containerd.exe -ldflags '-X github.com/containerd/containerd/version.Version=82df7d5 -X github.com/containerd/containerd/version.Revision=82df7d52086e1e39d7b56819d89ea75eab5eb9fd -X github.com/containerd/containerd/version.Package=github.com/containerd/containerd -s -w ' -tags "urfave_cli_no_docs"  ./cmd/containerd
# github.com/containerd/containerd/pkg/cri/sbserver/podsandbox
Error: pkg\cri\sbserver\podsandbox\sandbox_run.go:63:20: undefined: errors.Join
note: module requires Go 1.20
# github.com/containerd/containerd/runtime/v2
Error: runtime\v2\shim.go:383:16: undefined: errors.Join
note: module requires Go 1.20
# github.com/containerd/containerd/plugins/streaming
Error: plugins\streaming\manager.go:265:16: undefined: errors.Join
note: module requires Go 1.20
# github.com/containerd/containerd/snapshots/storage
Error: snapshots\storage\metastore.go:141:19: undefined: errors.Join
note: module requires Go 1.20
# github.com/containerd/containerd/pkg/cri/server
Error: pkg\cri\server\sandbox_stats_list.go:51:33: undefined: errors.Join
note: module requires Go 1.20
mingw32-make: *** [Makefile.windows:32: bin/containerd.exe] Error 1
Error: Process completed with exit code 2.

Use containerd version from go.mod when checking out and building
upstream containerd for testing.

containerd integration tests updated in 1.6.20 to work on windows.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
(cherry picked from commit de0e116)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
(cherry picked from commit f5c5797)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Contributor Author

thaJeztah commented Sep 18, 2023

Cherry-picked that one; some minor conflicts in go.mod due to 478b6da not being in this branch, but I didn't want to risk adding newer dependencies, so instead, I re-ran go mod tidy and go mod vendor)

@thaJeztah
Copy link
Contributor Author

And.. 🙈 now Ci needs approval again 😅

@kiashok
Copy link
Contributor

kiashok commented Sep 18, 2023

#1881 this PR should take care of fixing all the test failures

@thaJeztah
Copy link
Contributor Author

DOH! I didn't see that one (or I didn't play close attention). 🙈

@kiashok
Copy link
Contributor

kiashok commented Sep 18, 2023

DOH! I didn't see that one (or I didn't play close attention). 🙈

Ah no I had drafted it to check status of tests before un-drafting but couldn't get to it last week.

@thaJeztah
Copy link
Contributor Author

Let me close this one in favour of #1881 (thanks!)

@thaJeztah thaJeztah closed this Sep 18, 2023
@thaJeztah thaJeztah deleted the 0.11_backport_fix_ci branch September 25, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants