-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/0.11 backport] [ci] Fix integration test failure #1909
Conversation
|
One failure on Window-2022; I guess not related to this PR, is that a known flaky test?
And build failures in one part, because it looks like it depends on a version of containerd that requires go1.21;
|
Use containerd version from go.mod when checking out and building upstream containerd for testing. containerd integration tests updated in 1.6.20 to work on windows. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> (cherry picked from commit de0e116) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> (cherry picked from commit f5c5797) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
9797101
to
8320dc3
Compare
Cherry-picked that one; some minor conflicts in |
And.. 🙈 now Ci needs approval again 😅 |
#1881 this PR should take care of fixing all the test failures |
DOH! I didn't see that one (or I didn't play close attention). 🙈 |
Ah no I had drafted it to check status of tests before un-drafting but couldn't get to it last week. |
Let me close this one in favour of #1881 (thanks!) |
(cherry picked from commit f5c5797)