Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Update manifest; go generate #1919

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

helsaawy
Copy link
Contributor

@helsaawy helsaawy commented Sep 28, 2023

Update description in manifest used for test/ binaries.

Add test/tools.go (similar to tools/tools.go), to track goversioninfo command.

Update .github/workflows/ci.yml to run go generate from within test/ to validate that generated files (ie, syso files in test/pkg/manifest) are up to date (similar to what is done for the root module)

Copy link
Contributor

@yyatmsft yyatmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you state in the description that the purpose for the change is to validate that the syso files being checked in are up to date?

Update description in manifest used for `test/` binaries.

Add `test/tools.go` (similar to `tools/tools.go`), to track
`goversioninfo` command.

Update `.github/workflows/ci.yml` to run `go generate` from within
`test/`.

Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Copy link
Contributor

@msscotb msscotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@helsaawy helsaawy merged commit cff5c86 into microsoft:main Dec 6, 2023
17 of 19 checks passed
@helsaawy helsaawy deleted the mainfest-desc branch December 6, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants