[test] Log to ETW for benchmarks; retry layer removal #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write logs to ETW instead of stdout when running benchmarks to mimic actual deployments. Add log level to `Run-Test.ps1` helper script. Add `RemoveAll` function that wraps and retries `os.RemoveAll` (waiting in between attempts) since the OS may take a while to remove locks on a directory after handles are closed. Bug: defer uVM cleanup after creation (not start) during tests. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
| tb.Cleanup(func() { cleanup(ctx) }) | ||
| Start(ctx, tb, vm) |
There was a problem hiding this comment.
what's the issue here?
There was a problem hiding this comment.
if Start fails, it wont get to the cleanup call afterwards, so the uVM wont be closed and removed
its not a big issue, but still notcorrect
katiewasnothere
approved these changes
Oct 24, 2023
anmaxvl
approved these changes
Oct 24, 2023
darracott
pushed a commit
to KenGordon/hcsshim
that referenced
this pull request
Oct 30, 2023
Write logs to ETW instead of stdout when running benchmarks to mimic actual deployments. Add log level to `Run-Test.ps1` helper script. Add `RemoveAll` function that wraps and retries `os.RemoveAll` (waiting in between attempts) since the OS may take a while to remove locks on a directory after handles are closed. Bug: defer uVM cleanup after creation (not start) during tests. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> Signed-off-by: Joe Powell <joepowell@microsoft.com>
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Write logs to ETW instead of stdout when running benchmarks to mimic actual deployments. Add log level to `Run-Test.ps1` helper script. Add `RemoveAll` function that wraps and retries `os.RemoveAll` (waiting in between attempts) since the OS may take a while to remove locks on a directory after handles are closed. Bug: defer uVM cleanup after creation (not start) during tests. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write logs to ETW instead of stdout when running benchmarks to mimic actual deployments.
Add log level to
Run-Test.ps1helper script.Add
RemoveAllfunction that wraps and retriesos.RemoveAll(waiting in between attempts) since the OS may take a while to remove locks on a directory after handles are closed.Bug: defer uVM cleanup after creation (not start) during tests.