Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using new errdefs repo #2016

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

kiashok
Copy link
Contributor

@kiashok kiashok commented Feb 1, 2024

Errdefs was moved out as a pkg from containerd/containerd to its own separate repo at containerd/errdefs. Switching to this helps remove containerd cyclic dependency that is coming from hcsshim tag on containerd main branch

@kiashok kiashok requested a review from a team as a code owner February 1, 2024 00:56
Signed-off-by: Kirtana Ashok <kiashok@microsoft.com>
@kiashok
Copy link
Contributor Author

kiashok commented Feb 1, 2024

image

test failure is unrelated to the change being made here

Copy link
Contributor

@anmaxvl anmaxvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiashok kiashok merged commit b0d91fb into microsoft:main Feb 1, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants