Jterry75/containerd runhcs shim fixes #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crosbymichael - FYI only |
|
@jterry75 thanks! |
|
@jhowardmsft - I thought we already fixed this issue with CI? |
Whaaaa? That shouldn't be happening. |
Occasionally the product will fail the state query and return "operation is not valid in the current sate". Rather than returning an error in this case we want to return state "unknown" with a valid json output for clients to be able to handle. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
jterry75
force-pushed
the
jterry75/containerd-runhcs-shim_fixes
branch
from
a9678b0 to
56a3adc
Compare
|
@jhowardmsft - PTAL |
|
Nice, thanks! |
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Mar 17, 2021
Change HotRemove NIC to warning instead of error
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…unhcs-shim_fixes Jterry75/containerd runhcs shim fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
runhcs statewhere we return an error rather than status unknown if the gcs cannot be reached but in the starting phase.Removes an additional newline in an error making it easier to match.
Adds
runhcs create-scratchthat creates a ext4 formatted vhdx at the target path.Adds
runhcs tart2vhdthat converts a given tar to vhd at the target path.