WCOW: Use commandline in spec if populated #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jterry75
reviewed
Feb 1, 2019
|
|
||
| // escapeArgs makes a Windows-style escaped command line from a set of arguments | ||
| func escapeArgs(args []string) string { | ||
| escapedArgs := make([]string, len(args)) |
There was a problem hiding this comment.
You could use a strings.Builder and avoid the additional array alloc
There was a problem hiding this comment.
@jterry75 Happy to change if you think it's important enough.
|
Seems fine to me. Let me know when this gets upstreamed and we get this officially |
jstarks
reviewed
Feb 1, 2019
lowenna
force-pushed
the
jjh/commandline
branch
from
f1d25b6 to
a79ddd5
Compare
|
Update LGTM. I like that we no longer accept |
lowenna
force-pushed
the
jjh/commandline
branch
from
a79ddd5 to
9a813f6
Compare
Signed-off-by: John Howard <jhoward@microsoft.com>
lowenna
force-pushed
the
jjh/commandline
branch
from
9a813f6 to
a9d902e
Compare
Signed-off-by: John Howard <jhoward@microsoft.com> This is the version with `CommandLine` added.
lowenna
force-pushed
the
jjh/commandline
branch
from
a9d902e to
31fdae3
Compare
|
@jterry75 This one is ready to go. Updated to the latest vendor of the runtime-spec. |
lowenna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
@jterry75 Don't merge yet - the vendor part is hacked pending opencontainers/runtime-spec#998 being merged. Have done end-to-end verification of this working with docker with the containerd back-end for runtime.