Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy histopathology folder into hi-ml #181

Merged
merged 49 commits into from
Feb 15, 2022
Merged

Copy histopathology folder into hi-ml #181

merged 49 commits into from
Feb 15, 2022

Conversation

mebristo
Copy link
Member

@mebristo mebristo commented Feb 2, 2022

Copy histopathology code from innereye-deeplearning into hi-ml.

Please follow the guidelines for PRs contained here. Checklist:

  • Ensure that your PR is small, and implements one change.
  • Add unit tests for all functions that you introduced or modified.
  • Run PyCharm's code cleanup tools on your Python files.
  • Ensure that documentation renders correctly in Sphinx (run Sphinx via make html in the `docs folder)
  • Link the correct GitHub issue for tracking.
  • Update the Changelog file: Describe your change in terms of
    Added/Changed/Removed/... in the "Upcoming" section.
  • When merging your PR, replace the default merge message with a brief description of your PR,
    and if needed a motivation why that change was required.

@mebristo mebristo marked this pull request as ready for review February 7, 2022 17:10
ant0nsc
ant0nsc previously approved these changes Feb 8, 2022
Copy link
Contributor

@vale-salvatelli vale-salvatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I focused on the histo part, it looks OK but I couldn't look in detail at all the files - I assumed they were copied over from the other repo. If there is some specific change you would like me to look into please let me know.

ant0nsc
ant0nsc previously approved these changes Feb 15, 2022
@mebristo mebristo merged commit b8b5298 into main Feb 15, 2022
@mebristo mebristo deleted the mebristo/move_histo branch February 15, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants