-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy histopathology folder into hi-ml #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ant0nsc
previously approved these changes
Feb 8, 2022
hi-ml-histopathology/src/SSL/datamodules_and_datasets/cifar_datasets.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/SSL/datamodules_and_datasets/cxr_datasets.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/SSL/datamodules_and_datasets/cxr_datasets.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/SSL/lightning_containers/ssl_container.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/SSL/lightning_containers/ssl_container.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/SSL/datamodules_and_datasets/cifar_datasets.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/histopathology/configs/classification/DeepSMILECrck.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I focused on the histo part, it looks OK but I couldn't look in detail at all the files - I assumed they were copied over from the other repo. If there is some specific change you would like me to look into please let me know.
hi-ml-histopathology/src/histopathology/configs/classification/BaseMIL.py
Show resolved
Hide resolved
ant0nsc
previously approved these changes
Feb 15, 2022
ant0nsc
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy histopathology code from innereye-deeplearning into hi-ml.
Please follow the guidelines for PRs contained here. Checklist:
make html
in the `docs folder)Added/Changed/Removed/... in the "Upcoming" section.
and if needed a motivation why that change was required.