Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Pass cycle mode to the trainer for SSL, Crossval_index check #248

Merged
merged 7 commits into from
Mar 17, 2022

Conversation

ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented Mar 17, 2022


Guidelines

Please follow the guidelines for PRs contained here. Checklist:

  • Ensure that your PR is small, and implements one change
  • Give your PR title one of the prefixes ENH, BUG, STYLE, DOC, DEL to indicate what type of change that is (see CONTRIBUTING)
  • Link the correct GitHub issue for tracking
  • Add unit tests for all functions that you introduced or modified
  • Run automatic code formatting / linting on all files ("Format Document" Shift-Alt-F in VSCode)
  • Ensure that documentation renders correctly in Sphinx (run Sphinx via make html in the docs folder)

Change the default merge message

When completing your PR, you will be asked for a title and an optional extended description. By default, the extended description will be a concatenation of the individual
commit messages. Please DELETE/REPLACE that with a human readable extended description for non-trivial PRs.

@ant0nsc ant0nsc changed the title BUG: Pass cycle mode to the trainer for SSL models to work around bug in PL 1.5.5 BUG: Pass cycle mode to the trainer for SSL Mar 17, 2022
@ant0nsc ant0nsc changed the title BUG: Pass cycle mode to the trainer for SSL BUG: Pass cycle mode to the trainer for SSL, Crossval_index check Mar 17, 2022
@ant0nsc ant0nsc enabled auto-merge (squash) March 17, 2022 15:59
@ant0nsc ant0nsc requested a review from mebristo March 17, 2022 16:00
@ant0nsc ant0nsc merged commit 2b8a1fe into main Mar 17, 2022
@ant0nsc ant0nsc deleted the antonsc/cycle_mode branch March 17, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: cross validation index check fails on last index Bug: SimCLR jobs use the wrong cycle mode
2 participants