Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Better handling of duplicates when merging conda envs #257

Merged
merged 13 commits into from
Mar 23, 2022
Merged

ENH: Better handling of duplicates when merging conda envs #257

merged 13 commits into from
Mar 23, 2022

Conversation

mebristo
Copy link
Member

@mebristo mebristo commented Mar 21, 2022 •
edited
Loading

If duplicates are encountered when merging conda environment files, if exactly one such package is pinned ('==' for pip packages and '=' for conda), use that. Otherwise, raise an exception.

@mebristo mebristo changed the title DRAFT: better handling of duplicate packages when merging conda environments ENH: better handling of duplicate packages when merging conda environments Mar 23, 2022
@mebristo mebristo changed the title ENH: better handling of duplicate packages when merging conda environments ENH: Better handling of duplicate packages when merging conda environments Mar 23, 2022
@mebristo mebristo marked this pull request as ready for review March 23, 2022 16:32
@mebristo mebristo changed the title ENH: Better handling of duplicate packages when merging conda environments ENH: Better handling of duplicates when merging conda envs Mar 23, 2022
ant0nsc
ant0nsc previously approved these changes Mar 23, 2022
View reviewed changes
Copy link
Collaborator

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good as is, but maybe some small-fry cleanup that would be nice

@mebristo mebristo enabled auto-merge (squash) March 23, 2022 18:15
@mebristo mebristo merged commit 60bdcec into main Mar 23, 2022
@mebristo mebristo deleted the antonsc/smart_merge branch March 23, 2022 22:12
@ant0nsc ant0nsc linked an issue Mar 24, 2022 that may be closed by this pull request
Pin versions of pytorch-lightning and other packages in hi-ml-histo #251
Closed
@ant0nsc ant0nsc mentioned this pull request Mar 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant0nsc ant0nsc ant0nsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin versions of pytorch-lightning and other packages in hi-ml-histo
2 participants
@mebristo @ant0nsc