Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Group code coverage by folder #368

Merged
merged 3 commits into from
May 20, 2022
Merged

ENH: Group code coverage by folder #368

merged 3 commits into from
May 20, 2022

Conversation

ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented May 20, 2022

Using the Codecov flags to get better reporting for monorepos

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #368 (a1485a3) into main (f67ea46) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
hi-ml 80.86% <ø> (?)
hi-ml-azure 81.51% <ø> (?)
hi-ml-histopathology 75.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/histopathology/datasets/panda_tiles_dataset.py 57.14% <0.00%> (-6.02%) ⬇️
...istopathology/src/histopathology/models/deepmil.py 89.94% <0.00%> (-1.02%) ⬇️
...-histopathology/src/histopathology/utils/naming.py 98.43% <0.00%> (+0.05%) ⬆️

@ant0nsc ant0nsc requested review from fepegar and kenza-bouzid May 20, 2022 13:11
Copy link
Contributor

@kenza-bouzid kenza-bouzid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks, @ant0nsc. I've been reading the docs and they say the flag name must be passed in the uploading command. Do we need to add that?

@ant0nsc
Copy link
Collaborator Author

ant0nsc commented May 20, 2022

@fepegar ,we are using the GitHub action, that has a flags argument too, see the work flow file

@fepegar
Copy link
Contributor

fepegar commented May 20, 2022

@fepegar ,we are using the GitHub action, that has a flags argument too, see the work flow file

Oh, I see. Thanks for clarifying!

@ant0nsc ant0nsc merged commit 0ca31d4 into main May 20, 2022
@ant0nsc ant0nsc deleted the antonsc/codecov_flags branch May 20, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants