Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Default parameters in DeepSMILECRCk container #440

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

harshita-s
Copy link
Contributor

@harshita-s harshita-s commented Jun 16, 2022

We use caching with pre-trained encoders in DeepMIL for TCGA-CRCk. This is now enabled by default in DeepSMILECRCk container through the is_caching parameter, by setting it to True. Also, num_top_slides is set to 0 by default, to avoid errors arising from caching in outputs handler for TCGA-CRCk.

Copy link
Contributor

@kenza-bouzid kenza-bouzid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please keep in mind that setting num_top_slides to 0 disables top and bottom tiles plots and not slides outputs. Slides outputs (thumbnails and attention heatmaps) are disabled by default if a SlidesDataset is not provided which is the case for TCGACrck.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #440 (40ce46e) into main (703845a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
hi-ml-histopathology 79.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...opathology/configs/classification/DeepSMILECrck.py 63.63% <ø> (ø)

@harshita-s
Copy link
Contributor Author

LGTM, please keep in mind that setting num_top_slides to 0 disables top and bottom tiles plots and not slides outputs. Slides outputs (thumbnails and attention heatmaps) are disabled by default if a SlidesDataset is not provided which is the case for TCGACrck.

Thank you @kenza-bouzid. I have modified the description now.

@harshita-s harshita-s merged commit f07d6f3 into main Jun 16, 2022
@harshita-s harshita-s deleted the hsharma/crck_new branch June 16, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants