Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Remove the dependency on Lightning and Lightning Bolts #466

Merged
merged 4 commits into from
Jun 27, 2022
Merged

ENH: Remove the dependency on Lightning and Lightning Bolts #466

merged 4 commits into from
Jun 27, 2022

Conversation

ozan-oktay
Copy link
Contributor

Addresses #464

  • Removes the dependency on pytorch-lightning and bolts.
  • Wraps the torchvision resnet class to return the intermediate layer activations.

@ozan-oktay ozan-oktay requested review from fepegar and Shruthi42 June 27, 2022 15:19
@fepegar fepegar changed the title [ENH] Multimodal -- Remove the dependency on pl and pl-bolt ENH: Remove the dependency on Lightning and Lightning Bolts Jun 27, 2022
@fepegar
Copy link
Contributor

fepegar commented Jun 27, 2022

It looks like there's a test that is still trying to import Bolts.

fepegar
fepegar requested changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test is failing because it tries to import Bolts. I can work on fixing docstrings and ensuring the new classes are shown on the API docs.

@ozan-oktay
Copy link
Contributor Author

It looks like there's a test that is still trying to import Bolts.

Yes, I can fix this one. Thanks.

@fepegar fepegar marked this pull request as ready for review June 27, 2022 15:47
fepegar
fepegar approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fepegar fepegar enabled auto-merge (squash) June 27, 2022 15:48
@fepegar fepegar merged commit 8725e69 into main Jun 27, 2022
@fepegar fepegar deleted the ozoktay/remove_pl_dependency branch June 27, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant0nsc ant0nsc ant0nsc approved these changes

@fepegar fepegar fepegar approved these changes

@Shruthi42 Shruthi42 Awaiting requested review from Shruthi42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ozan-oktay @fepegar @ant0nsc