Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update documentation for hi-ml-multimodal #493

Merged
merged 7 commits into from
Jul 8, 2022
Merged

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented Jul 6, 2022

Update of the landing page for the multimodal package, in preparation for the upcoming model release.

@fepegar
Copy link
Contributor Author

fepegar commented Jul 6, 2022

It looks like this:

Web capture_6-7-2022_17560_hi-ml--493 org readthedocs build

@fepegar fepegar requested review from ozan-oktay and Shruthi42 July 6, 2022 16:59
@fepegar fepegar added documentation Improvements or additions to documentation hi-ml-multimodal Issues related to the hi-ml-multimodal package labels Jul 6, 2022
@fepegar fepegar marked this pull request as ready for review July 6, 2022 17:01
Copy link
Contributor

@ozan-oktay ozan-oktay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you so much Fernando 👍

Copy link
Contributor Author

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions addressed in da4577e. Thanks, @ozan-oktay!

@fepegar fepegar requested a review from Shruthi42 July 7, 2022 11:56
@fepegar
Copy link
Contributor Author

fepegar commented Jul 7, 2022

@benbo, can you please take a look?

@ant0nsc, I wasn't able to request Ben's review. Shall we add him to the InnerEye GitHub team? I don't have admin permissions to it.

EDIT: I guess it's not necessary. @benbo, have you linked your GitHub and Microsoft accounts?

@benbo
Copy link

benbo commented Jul 7, 2022

I'd like to suggest that we move the reference up to the top and have the bibtex at the bottom. Something like:

This toolbox provides models for working with multi-modal health data, as introduced in our paper accepted at ECCV 2022:

Boecking, B., Usuyama, N., Bannur, S., Castro, D., Schwaighofer, A., Hyland, S., Wetscherek, M., Naumann, T., Nori, A., Alvarez-Valle, J., Poon, H., & Oktay, O. (2022). Making the Most of Text Semantics to Improve Biomedical Vision–Language Processing ([preprint][7])

@fepegar fepegar marked this pull request as draft July 7, 2022 17:03
@ant0nsc
Copy link
Collaborator

ant0nsc commented Jul 8, 2022

@fepegar , I can't add @benbo because his account is not yet part of the microsoft org.

@fepegar fepegar marked this pull request as ready for review July 8, 2022 10:37
@fepegar fepegar merged commit 866203e into main Jul 8, 2022
@fepegar fepegar deleted the update-multimodal-docs branch July 8, 2022 10:59
@fepegar
Copy link
Contributor Author

fepegar commented Jul 8, 2022

Thanks all for the reviews. @benbo, let's edit in future PRs, if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation hi-ml-multimodal Issues related to the hi-ml-multimodal package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants