Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Show run ID and prefix if no files are found #528

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented Jul 21, 2022

I'm getting this error on Azure ML:

Traceback (most recent call last):
  File "radt5-dev/downstream_evaluation.py", line 142, in <module>
    main()
  File "radt5-dev/downstream_evaluation.py", line 138, in main
    run(args)
  File "radt5-dev/downstream_evaluation.py", line 131, in run
    results = evaluate_tasks(args)
  File "radt5-dev/downstream_evaluation.py", line 122, in evaluate_tasks
    trivial_baseline=args.trivial_baseline,
  File "radt5-dev/evaluation_utils/checkpoint.py", line 100, in get_model
    load_for_inference=True,
  File "radt5-dev/evaluation_utils/checkpoint.py", line 68, in get_pretrained_model
    workspace_config_path=azure_params.workspace_config_path)
  File "/azureml-envs/azureml_0bff92306a31e8d8ca795527d96b3826/lib/python3.7/site-packages/health_azure/utils.py", line 1035, in download_files_from_run_id
    _download_files_from_run(run, output_folder, prefix=prefix, validate_checksum=validate_checksum)
  File "/azureml-envs/azureml_0bff92306a31e8d8ca795527d96b3826/lib/python3.7/site-packages/health_azure/utils.py", line 1002, in _download_files_from_run
    raise ValueError("No such files were found for this Run.")
ValueError: No such files were found for this Run.

I would've liked to see which files the error is talking about. This PR should help generate a more informative error message.

@fepegar fepegar requested a review from mebristo July 21, 2022 14:10
@fepegar fepegar marked this pull request as draft July 21, 2022 14:10
@fepegar fepegar requested a review from ant0nsc July 21, 2022 14:11
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #528 (c6b712f) into main (be10621) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

Flag Coverage Δ
hi-ml 80.39% <ø> (ø)
hi-ml-azure 25.64% <0.00%> (-0.02%) ⬇️
hi-ml-cpath 77.27% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hi-ml-azure/src/health_azure/utils.py 26.16% <0.00%> (-0.04%) ⬇️
hi-ml-cpath/src/health_cpath/models/encoders.py 88.31% <0.00%> (-2.23%) ⬇️
hi-ml-cpath/src/SSL/data/dataset_cls_utils.py
...-ml-cpath/src/SSL/configs/PANDA_SimCLRContainer.py 61.90% <0.00%> (ø)
...i-ml-cpath/src/SSL/configs/HistoSimCLRContainer.py 41.02% <0.00%> (ø)
...i-ml-cpath/src/SSL/configs/CRCK_SimCLRContainer.py 92.30% <0.00%> (ø)
.../src/health_cpath/datasets/dataset_return_index.py 93.33% <0.00%> (ø)

@fepegar fepegar marked this pull request as ready for review July 21, 2022 14:23
@fepegar fepegar marked this pull request as draft July 21, 2022 14:25
@fepegar fepegar marked this pull request as ready for review July 21, 2022 14:27
@fepegar fepegar requested a review from Shruthi42 July 21, 2022 14:27
@fepegar fepegar requested a review from peterhessey July 21, 2022 17:07
@fepegar fepegar merged commit 71a993a into main Jul 22, 2022
@fepegar fepegar deleted the show-run-id-prefix branch July 22, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants