Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Adding gradient accumulation flag to trainer #592

Merged
merged 5 commits into from
Sep 5, 2022
Merged

ENH: Adding gradient accumulation flag to trainer #592

merged 5 commits into from
Sep 5, 2022

Conversation

vale-salvatelli
Copy link
Contributor

Adding gradient accumulation flag to enable gradient accumulation in Pytorch Lightening containers

@vale-salvatelli vale-salvatelli changed the title ENH: adding gradient accumulation flag to trainer ENH: adding gradient accumulation flag to trainer Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022 •
edited
Loading

Codecov Report

Merging #592 (c2a8b2a) into transfer_main (f7c21a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c2a8b2a differs from pull request most recent head f1c8e05. Consider uploading reports for the commit f1c8e05 to get more accurate results

Impacted file tree graph

Flag Coverage Δ
hi-ml 82.46% <100.00%> (+<0.01%) ⬆️
hi-ml-azure 25.47% <ø> (ø)
hi-ml-cpath 76.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hi-ml/src/health_ml/model_trainer.py 75.90% <ø> (ø)
hi-ml/src/health_ml/deep_learning_config.py 88.03% <100.00%> (+0.05%) ⬆️

@ant0nsc ant0nsc changed the title ENH: adding gradient accumulation flag to trainer ENH: Adding gradient accumulation flag to trainer Sep 5, 2022
vale-salvatelli and others added 3 commits September 5, 2022 15:56
@vale-salvatelli
adding test
baf4f03
@vale-salvatelli @ant0nsc
Update doc in deep_learning_config.py
095a39d 
Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
@vale-salvatelli
fix string length
f1c8e05
@vale-salvatelli vale-salvatelli merged commit 378fbb3 into transfer_main Sep 5, 2022
@vale-salvatelli vale-salvatelli deleted the vsalva/adding_gr_acc branch September 5, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant0nsc ant0nsc ant0nsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vale-salvatelli @ant0nsc