-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Enable Global Similarity Comparison Between Text and Image Inputs #606
Conversation
hi-ml-multimodal/src/health_multimodal/image/inference_engine.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ozan-oktay. It would be best to make the methods slightly more modular: one function to load, one function to transform, one function to compute embeddings. This will maximise flexibility and simplify testing. I'm happy to work on that if you like.
@fepegar The PR is not introducing any new loading or transformation functions -- It's using the existing class methods to return a global embedding that is similar to patch embedding computation. It also adds a separate method in VLP inference engine to return a similarity score. Please feel free to create a separate issue for the idea you have in mind, and if there is something particularly applicable within this context, please let me know. Thanks. |
hi-ml-multimodal/src/health_multimodal/image/inference_engine.py
Outdated
Show resolved
Hide resolved
hi-ml-multimodal/test_multimodal/vlp/test_vlp_inference_engine.py
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
…icrosoft/hi-ml into ozoktay/multimodal_global_similarities
…icrosoft/hi-ml into ozoktay/multimodal_global_similarities
#604
Proposed changes: