Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Improve Amulet support and documentation #615

Merged
merged 1 commit into from
Sep 27, 2022
Merged

ENH: Improve Amulet support and documentation #615

merged 1 commit into from
Sep 27, 2022

Conversation

ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented Sep 27, 2022

Merge #612 from main:

  • Move all Amulet-related code to a separate module
  • Add bug fix for RANK environment to hi-ml runner
  • Improve documentation and add standalone example script

@ant0nsc
ENH: Improve Amulet support and documentation (#612)
99dff9f 
- Move all Amulet-related code to a separate module
- Add bug fix for `RANK` environment to `hi-ml` runner
- Improve documentation and add standalone example script
@codecov
Copy link

codecov bot commented Sep 27, 2022 •
edited
Loading

Codecov Report

Merging #615 (99dff9f) into transfer_main (d385f33) will decrease coverage by 0.02%.
The diff coverage is 57.37%.

Impacted file tree graph

Flag Coverage Δ
hi-ml 82.53% <80.00%> (+0.01%) ⬆️
hi-ml-azure 25.84% <47.91%> (+0.42%) ⬆️
hi-ml-cpath 76.63% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hi-ml-azure/src/health_azure/amulet.py 44.44% <44.44%> (ø)
hi-ml/src/health_ml/deep_learning_config.py 84.78% <66.66%> (+0.06%) ⬆️
hi-ml-azure/src/health_azure/himl.py 55.39% <100.00%> (+0.21%) ⬆️
hi-ml-azure/src/health_azure/utils.py 25.58% <100.00%> (-0.40%) ⬇️
...src/health_cpath/configs/classification/BaseMIL.py 80.28% <100.00%> (+0.57%) ⬆️
hi-ml/src/health_ml/runner.py 85.91% <100.00%> (+0.20%) ⬆️

@ant0nsc ant0nsc enabled auto-merge (squash) September 27, 2022 13:20
@ant0nsc ant0nsc merged commit 108ffae into transfer_main Sep 27, 2022
@ant0nsc ant0nsc deleted the antonsc/transfer_amlt2 branch September 27, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenza-bouzid kenza-bouzid kenza-bouzid approved these changes

@mebristo mebristo Awaiting requested review from mebristo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ant0nsc @kenza-bouzid