Update conversion ranks for minimum precision types #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just updates the conversion rank for minimum precision types which are now represented in the Basic.types section. TL;DR: min10int < min12int < min16int < int16_t < int32_t < int64_t min10uint < min12uint < min16uint < uint16_t < uint32_t < uint64_t min10float < min12float < min16float < half < float < double
coopp
approved these changes
Apr 19, 2024
There is not a 10, 12, and 16 for each type. Float has 10 and 16, int has 12 and 16, and uint has only 16.
damyanp
approved these changes
Apr 25, 2024
llvm-beanz
added a commit
to llvm-beanz/llvm-project
that referenced
this pull request
Apr 26, 2024
This PR fixes bugs in HLSL floating conversions. HLSL always has `half`, `float` and `double` types, which promote in the order: `half`->`float`->`double` and convert in the order: `double`->`float`->`half` As with other conversions in C++, promotions are preferred over conversions. We do have floating conversions documented in the draft language specification (https://microsoft.github.io/hlsl-specs/specs/hlsl.pdf [Conv.rank.float]) although the exact language is still in flux (microsoft/hlsl-specs#206). Resolves llvm#81047
llvm-beanz
added a commit
to llvm/llvm-project
that referenced
this pull request
May 2, 2024
This PR fixes bugs in HLSL floating conversions. HLSL always has `half`, `float` and `double` types, which promote in the order: `half`->`float`->`double` and convert in the order: `double`->`float`->`half` As with other conversions in C++, promotions are preferred over conversions. We do have floating conversions documented in the draft language specification (https://microsoft.github.io/hlsl-specs/specs/hlsl.pdf [Conv.rank.float]) although the exact language is still in flux (microsoft/hlsl-specs#206). Resolves #81047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just updates the conversion rank for minimum precision types which are now represented in the Basic.types section.
I've iterated on this a few times and reduced it down to just the min16{int|uint|float} types because those are the only types DXC actually supports. Using any of the other types produces a warning and they get treated as the corresponding min16 type.
The promotion orders are as follows:
min16int < int16_t < int32_t < int64_t
min16uint < uint16_t < uint32_t < uint64_t
min16float < half < float < double